RFR: 7113208: Incorrect javadoc on java.net.DatagramPacket.setLength() [v3]
Jaikiran Pai
jpai at openjdk.org
Thu Sep 1 07:01:14 UTC 2022
> Can I please get a review of this javadoc only change for `DatagramPacket#setLength()` method? This addresses https://bugs.openjdk.org/browse/JDK-7113208.
>
> I haven't create a CSR because the javadoc was already stating the correct behaviour in the `@throws` documentation as follows:
>
>> @throws IllegalArgumentException if the length is negative,
> * or if the length plus the offset is greater than the
> * length of the packet's data buffer.
>
> This commit merely fixes the main part of the javadoc.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
review comment - use Preconditions
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10037/files
- new: https://git.openjdk.org/jdk/pull/10037/files/addffb27..6c762013
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10037&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10037&range=01-02
Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/10037.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10037/head:pull/10037
PR: https://git.openjdk.org/jdk/pull/10037
More information about the net-dev
mailing list