RFR: 8170305: URLConnection doesn't handle HTTP/1.1 1xx (informational) messages
Daniel Fuchs
dfuchs at openjdk.org
Fri Sep 9 11:49:58 UTC 2022
On Fri, 9 Sep 2022 11:21:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8170305?
>
> The commit in this PR changes the internal implementation of `HttpURLConnection` to ignore interim informational 1xx responses from server and continue to wait for the final response. This is a similar fix to what we did in the new `HttpClient` API in https://github.com/openjdk/jdk/pull/10169.
>
> A new test has been added to use the `HttpURLConnection` to reproduce the issue and verify the fix.
>
> tier1, tier2 and tier3 testing is in progress with this change.
LGTM globally. We're not supposed to receive 101 if we didn't ask for an upgrade (and we never should), but what happens if we still receive 101?
It could be beneficial to add that to your test as well.
-------------
PR: https://git.openjdk.org/jdk/pull/10229
More information about the net-dev
mailing list