Integrated: 8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow

Alan Bateman alanb at openjdk.org
Wed Sep 28 13:13:44 UTC 2022


On Mon, 26 Sep 2022 15:35:28 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> BlockingChannelOps.java and BlockingSocketOps.java test virtual threads doing blocking I/O on channels and java.net sockets.
> 
> BlockingChannelOps has 32 tests at this time and takes nearly 120s to run due to several tests that sleep to improve the chances that threads are blocked. These sleeps can be replaced with a poll of the thread state so the test runs in 3-4s. BlockingSocketOps has be changed to do the same time.
> 
> In passing, I updated the tests in BlockingSocketOps that bound a ServerSocket to the wildcard address so they bind to the loopback address instead. This helps reduce potential interference in CI environments. I also put a workaround into BlockingChannelOps for macOS where the kernel appears to increase the amount of bytes that can be buffered in the socket sender buffer, it's otherwise too hard to test that socket writes block on that platform.

This pull request has now been integrated.

Changeset: 37f83b9b
Author:    Alan Bateman <alanb at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/37f83b9b8e007cd1153502540e9b1bf3cc713646
Stats:     610 lines in 2 files changed: 124 ins; 317 del; 169 mod

8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow

Reviewed-by: jpai

-------------

PR: https://git.openjdk.org/jdk/pull/10427


More information about the net-dev mailing list