RFR: 8294610: java/net/vthread/HttpALot.java is slow on Linux [v2]

Jaikiran Pai jpai at openjdk.org
Fri Sep 30 10:20:50 UTC 2022


On Fri, 30 Sep 2022 10:09:14 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update test comment to address review comments
>
> test/jdk/java/net/vthread/HttpALot.java line 34:
> 
>> 32:  * @comment This test runs with -Dsun.net.httpserver.nodelay=true
>> 33:  *          to enable TCP_NODELAY on the sockets "accept()"ed by the HttpServer. This is
>> 34:  *          to avoid occasional 40ms delays receiving responses from the server on Linux.
> 
> Thanks for the update the bug tag and improving the comment. Just a minor nit is that you might want to re-flow it to avoid 1 short line and two longer lines. Ignore if you want.

Hello Alan, what you suggest seems fine. So I've now updated the comment accordingly.

-------------

PR: https://git.openjdk.org/jdk/pull/10504


More information about the net-dev mailing list