RFR: 8294626: Improve URL protocol lower casing [v3]

[Claes Redestad]

On Fri, 30 Sep 2022 11:31:00 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Cleanups
>>  - Revert accidental import mangling
>
> src/java.base/share/classes/java/net/URL.java line 35:
> 
>> 33: import java.security.AccessController;
>> 34: import java.security.PrivilegedAction;
>> 35: import java.util.*;
> 
> Could we avoid the wildcards? Thanks!

Sorry for the noise - need to re-tame my IDE after getting set up on a new laptop..

> src/java.base/share/classes/java/net/URL.java line 439:
> 
>> 437:         }
>> 438: 
>> 439:         protocol = URLUtil.lowerCaseProtocol(protocol);
> 
> Maybe we could keep the name 'toLowerCase' in this file

I prefer explicitly calling out protocol since it's not intended to be used as a general purpose lower case utility method.

-------------

PR: https://git.openjdk.org/jdk/pull/10506