RFR: 8294610: java/net/vthread/HttpALot.java is slow on Linux [v3]

Daniel Fuchs dfuchs at openjdk.org
Fri Sep 30 13:34:19 UTC 2022


On Fri, 30 Sep 2022 12:18:51 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Hello Mark, it hasn't always been clear to me when to update the `@bug`. The contribution guide isn't completely clear either. So I usually update the bug id if the test change is substantial (in the way it affects the test). In this case, I've now taken Alan's suggestion to include the  `8284161` (the one which introduced the test for feature testing) along with the current bug id `8294610`. I am willing to drop the `8294610` from the `@bug` if there's some agreement towards it.
>> 
>> Alan has marked the JBS issue as `noreg-self`, so that's been taken care of.
>
> I think adding the original 8284161 is sufficient, but remove 8294610 as the convention has been not to include a test fix bugid in the @bug statement ... this is a correction I've had to apply in the past

I agree with Mark. The `@bug` tag serves to identify the test that needs to be run for a particular source code change. If the changes are all in the test itself, then there's no need for that information. The JBS issue will have a noreg-self keyword indicating that the test itself needs to be run, and that there's no need for any new non-regression test to test the change.

-------------

PR: https://git.openjdk.org/jdk/pull/10504


More information about the net-dev mailing list