RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v8]

[Jaikiran Pai]

On Wed, 12 Apr 2023 07:53:28 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> Can I get a review for this please? This change uses a Cleaner to check when java.net.Authenticator instances become unreachable, and then prunes the authentication cache for entries that correspond to that Authenticator and therefore cannot be used again. This stops the authentication cache from growing in size unbounded. Note, this only happens in the probably unusual case where more than one Authenticator object is used. Normally there is no reason to use more than one instance.
>> 
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to remove dependency on AuthCacheImpl in j.n.Authenticator

src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheValue.java line 47:

> 45:      * The default authentication cache
> 46:      */
> 47:     protected static AuthCacheImpl defCache = new AuthCacheImpl();

Do instances of `AuthCacheValue` get used concurrently (by different threads)? If so, should this `defCache` value be a `volatile`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1163899164