RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v8]

[Jaikiran Pai]

On Wed, 12 Apr 2023 07:53:28 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> Can I get a review for this please? This change uses a Cleaner to check when java.net.Authenticator instances become unreachable, and then prunes the authentication cache for entries that correspond to that Authenticator and therefore cannot be used again. This stops the authentication cache from growing in size unbounded. Note, this only happens in the probably unusual case where more than one Authenticator object is used. Normally there is no reason to use more than one instance.
>> 
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to remove dependency on AuthCacheImpl in j.n.Authenticator

src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java line 217:

> 215: 
> 216:     /** A cache to obtain credentials from if the default cache not to be used */
> 217:     transient AuthCacheImpl authcache; // may be null

Now that `AuthCacheValue` is no longer `Serializable` in this PR (and thus this `AuthenticationInfo` too isn't serializable), is the use of `transient` here and on some other fields in this class, needed anymore?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1163904933