RFR: 8306940: test/jdk/java/net/httpclient/XxxxInURI.java should call HttpClient::close

Jaikiran Pai jpai at openjdk.org
Thu Apr 27 01:44:23 UTC 2023


On Wed, 26 Apr 2023 15:51:27 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> The tests test/jdk/java/net/httpclient/*InURI.java create a lot of HttpClient instances.
> They should call HttpClient::close when the client is no longer needed.
> 
> The fix includes some cleanup of the test code, as well as an additional check on the response version.

Hello Daniel, these changes look fine to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13673#pullrequestreview-1403049484


More information about the net-dev mailing list