RFR: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails [v7]
Michael McMahon
michaelm at openjdk.org
Wed Aug 9 17:23:29 UTC 2023
On Tue, 8 Aug 2023 14:31:16 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which updates the javadoc of `java.net.InetAddress.getCanonicalHostName()` method to clarify its semantics? This addresses https://bugs.openjdk.org/browse/JDK-8313239.
>>
>> This a javadoc only change and the documentation is updated to match the current implementation. A CSR will be drafted for this change.
>
> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
>
> - Alan's suggestion - better wording
> - Alan's suggestion - consistency for "system configured" vs "system-wide"
src/java.base/share/classes/java/net/InetAddress.java line 825:
> 823:
> 824: /**
> 825: * Returns the fully qualified domain name for this address.
Maybe in the followup issue we could change "this address" to "the given address" considering it's a static method. It's not part of the spec regardless, so only a minor nit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15134#discussion_r1288915204
More information about the net-dev
mailing list