RFR: 8313356: Improve address selection in sun.net.NetworkClient

[Liam Miller-Cushon]

On Sat, 29 Jul 2023 12:11:25 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Please review this fix for [JDK-8313356](https://bugs.openjdk.org/browse/JDK-8313356), which improves address selection in `sun.net.NetworkClient` to consider all addresses returned by `InetAddress.getAllByName` instead of only connecting to the first one.
>> 
>> This follows the approach described in [JDK-8170568](https://bugs.openjdk.org/browse/JDK-8170568).
>
> The is a significant change to long standing behavior and will require discussion/consensus. It's probably a bit premature to create a PR without discussion on how it may be observed by existing deployments when the connection to the first address cannot be established. It also interacts with the "connect timeout", either changing its semantics or requiring adjustment for second/subsequent attempts. There is also the question on whether it would be better to focus on newer HTTP client rather than trying to get the legacy HTTP and HTTPS protocol handlers to support this.

@AlanBateman thanks for the comment, those are excellent points. I wasn't familiar with some of the history with JDK-8170568 when I opened this. I left a comment in https://bugs.openjdk.org/browse/JDK-8170568, and I am going to drop this PR for now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15078#issuecomment-1679726389