RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream

[Daniel Fuchs]

On Sat, 8 Jul 2023 06:15:13 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

> Please review the code change for [JDK-8306040](https://bugs.openjdk.org/browse/JDK-8306040). In the overridden "available" method of "HttpResponseInputStream" we are returning 1 after exploring all the code path.

Changes requested by dfuchs (Reviewer).

test/jdk/java/net/httpclient/HttpInputStreamAvailableTest.java line 29:

> 27:  * @summary HttpResponseInputStream.available() returns 1 on empty stream
> 28:  * @library /test/lib /test/jdk/java/net/httpclient/lib
> 29:  * @run testng/othervm HttpInputStreamAvailableTest

Could we use `junit/othervm` here

test/jdk/java/net/httpclient/HttpInputStreamAvailableTest.java line 50:

> 48: import org.testng.annotations.AfterTest;
> 49: import org.testng.annotations.BeforeTest;
> 50: import static org.testng.Assert.assertEquals;

Could you use jupiter annotation instead?

-------------

PR Review: https://git.openjdk.org/jdk/pull/14810#pullrequestreview-1582348653
PR Review Comment: https://git.openjdk.org/jdk/pull/14810#discussion_r1297049287
PR Review Comment: https://git.openjdk.org/jdk/pull/14810#discussion_r1297048561