RFR: JDK-8314517: some tests fail in case ipv6 is disabled on the machine

[Jaikiran Pai]

On Fri, 18 Aug 2023 06:53:19 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Some jtreg tests fail with ipv6 disabled on the machine, this should be improved in the tests (e.g. by using IPSupport.hasIPv6() ).

I've added a trivial review comment about one of the test method changes. Other than that, these changes look OK to me.

test/jdk/java/net/InetAddress/HostsFileOrderingTest.java line 91:

> 89:     @Test
> 90:     public void testOrdering() throws Exception {
> 91:         if (IPSupport.hasIPv6()) {

Hello Matthias, unlike changes to some other tests, this skips the entire test method if there's no IPv6 support. So perhaps add a System.out message that this test is skipped? I checked if `testng` has `assumeTrue` kind of API like junit, but I couldn't find any, so just returning by printing a System.out message might be enough.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15341#pullrequestreview-1586377503
PR Review Comment: https://git.openjdk.org/jdk/pull/15341#discussion_r1299719669