RFR: JDK-8311792: java/net/httpclient/ResponsePublisher.java fails intermittently with AssertionError: Found some outstanding operations [v2]

Daniel Fuchs dfuchs at openjdk.org
Thu Aug 24 10:31:30 UTC 2023


On Thu, 24 Aug 2023 10:25:57 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

>> Currently `ResponsePublisher` occasionally fails due to unreleased resources.
>> Updated test based on [AbstractThrowingPushPromises](https://github.com/openjdk/jdk/blob/b80001de0c0aeedeb412430660a4727fc26be98b/test/jdk/java/net/httpclient/AbstractThrowingPushPromises.java#L343) to ensure that non-shared clients get closed before further iterations run, this should limit the max number of clients that remain alive during the test.
>> 
>> I ran tiers 1-3 and everything is passing
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/java/net/httpclient/ResponsePublisher.java
>   
>   Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>

LGTM. Please make sure the changed test passes reliably in the CI before integrating.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15307#pullrequestreview-1593280666


More information about the net-dev mailing list