RFR: 8316738: java/net/httpclient/HttpClientLocalAddrTest.java failed in timeout

Daniel Fuchs dfuchs at openjdk.org
Fri Dec 8 10:01:13 UTC 2023


On Fri, 8 Dec 2023 06:56:03 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this trivial test only change which adds the `-Djdk.tracePinnedThreads=full` system property when launching the `HttpClientLocalAddrTest` test?
> 
> This test has failed with timeout (on a rare occasion). The test uses virtual threads for the HttpClient instances it uses and has 2 `@run` test definitions. One of it already uses `-Djdk.tracePinnedThreads=full` to help debug any pinned thread issues. The commit in this PR updates the other `@run` definition to use this same system property for the same reason.
> 
> The test continues to pass with this change.

Looks trivial and good to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17031#pullrequestreview-1772023956


More information about the net-dev mailing list