RFR: 8300268 : ServerImpl allows too many idle connections when using sun.net.httpserver.maxIdleConnections [v3]
Daniel Fuchs
dfuchs at openjdk.org
Tue Feb 7 16:02:15 UTC 2023
On Tue, 7 Feb 2023 15:40:48 GMT, Darragh Clarke <duke at openjdk.org> wrote:
>> Currently there is a race condition that can allow for too many 'idleConnections' in `ServerImpl`
>>
>> This PR adds a lock to make sure only one connection can be marked Idle at a time as well as a test that consistently failed before the change but which now passes.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>
> addressed comments
LGTM. Approved on the condition that the test is verified to be stable and that tier2 tests are passing.
Would be good to get @jaikiran review before integrating.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12413
More information about the net-dev
mailing list