RFR: 8301243: java/net/httpclient/http2/IdleConnectionTimeoutTest.java intermittent failure [v2]

[Daniel Fuchs]

On Thu, 9 Feb 2023 21:15:21 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

>> ### Description ###
>> Intermittent failures of this test are observed on frequent `HttpClient` test runs. The test checks that the same connection is not used twice for two seperate requests if an Idle Connection Timeout occurs by verifying that the client-side port does not use the same port. It also verifies that when an Idle Connection Timeout does not occur, the same connection is used by verifying that the port used in both requests is the same.
>> 
>> The issue here is that there is no guarantee that the ports used will not be the same for when an Idle Connection Timeout occurs and so the test will/does fail intermittently.
>> 
>> ### Summary of Changes & Justification ###
>> Instead of comparing the post numbers of the connections used for each request in all test cases, the connections themselves are now compared with calls to `hashCode()` like so. The connection instances themselves are accessed by using a customised `ExchangeSupplier` for the `Http2TestServer`.
>
> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8301243: Simplified changes to server handlers

LGTM! Thanks for making these changes.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12457