RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened

Alan Bateman alanb at openjdk.org
Sat Feb 11 07:19:26 UTC 2023


On Sat, 11 Feb 2023 05:42:52 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Good point, I'll look into that
>
> There's no special handling for such an exception type in place.
> 
> Could the "if non operational" state be passed to a call to an `Assumptions.assume...()` method instead of throwing?
> - https://junit.org/junit5/docs/current/user-guide/#writing-tests-assumptions
> 
> Other alternatives are:
> - https://junit.org/junit5/docs/current/user-guide/#writing-tests-conditional-execution
> - https://junit.org/junit5/docs/current/user-guide/#extensions-conditions

Thanks for checking. In that case, I suspect it will need to change to
`assumeTrue(IPSupport.currentConfigurationIsValid(), "Invalid networking configuration");`

-------------

PR: https://git.openjdk.org/jdk/pull/12513


More information about the net-dev mailing list