RFR: 8301964: Expensive fillInStackTrace operation in HttpURLConnection.getLastModified when no last-modified in response [v3]

Alan Bateman alanb at openjdk.org
Sun Feb 12 07:54:25 UTC 2023


On Wed, 8 Feb 2023 14:15:09 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> [JDK-8297211](https://bugs.openjdk.org/browse/JDK-8297211) (#11258) missed one case with date headers: `last-modified`, `date`, `expires`. We can avoid expensive NPE.
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8301964: Expensive fillInStackTrace operation in HttpURLConnection.getLastModified when no last-modified in response
>   
>   update copyright year

The changes looks okay, I just wonder why the try-catch around Date.parse catches Exception, should it be IllegalArgumentException?

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12451


More information about the net-dev mailing list