RFR: 8301463: Code in DatagramSocket still refers to resolved JDK-8237352 [v2]

[Daniel Fuchs]

On Mon, 13 Feb 2023 10:34:08 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> This appeared on the JDK 20 EC list last week. Initially I thought the comment and the usage of the NO_DELEGATE sentinel could be removed, but that is not the case as a special non-null value is still required.
>> 
>> That leaves a trivial change of just removing the comment in the two places.
>> 
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into datagram-8301463
>  - remove code change, leaving comment only deleted
>  - impl

LGTM. We unfortunately cannot really revert the change where the DatagramSocketAdaptor extends MulticastSocket, so the NO_DELEGATE trick is still needed. It's unfortunate because if JDK-8237352 had been implemented before that we would probably never have made DatagramSocketAdaptor extend MulticastSocket.

-------------

PR: https://git.openjdk.org/jdk/pull/12526