RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
Darragh Clarke
duke at openjdk.org
Tue Feb 14 14:44:39 UTC 2023
On Fri, 10 Feb 2023 15:43:35 GMT, Darragh Clarke <duke at openjdk.org> wrote:
> Updated `DatagramSocketMulticasting` to use Junit and also hardened the test to avoid occasional interference from other tests.
>
> - Test now uses Junit Assertions, in general if the assertion used had been `assertTrue(foo==bar)` I replaced it with `assertEquals(foo,bar)` though there are some cases where I used `assertTrue` or `assertFalse`
> - `testSendReceive` now retries up to 3 times if a message from an unexpected port is received
> - Both `testSendReceive` and `testSendNoReceive` both have messages that use the methods name instead of just "hello"
>
> Ran tiers 1-3 of tests as well as running this updated test to make sure it was stable
Thanks for the comments, I got sidetracked so it was a bit delayed but I've made those changes now
-------------
PR: https://git.openjdk.org/jdk/pull/12513
More information about the net-dev
mailing list