RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened [v3]

[Alan Bateman]

On Tue, 21 Feb 2023 11:56:59 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Updated `DatagramSocketMulticasting` to use Junit and also hardened the test to avoid occasional interference from other tests.
>> 
>> - Test now uses Junit Assertions, in general if the assertion used had been `assertTrue(foo==bar)` I replaced it with `assertEquals(foo,bar)` though there are some cases where I used `assertTrue` or `assertFalse`
>> - `testSendReceive` now retries up to 3 times if a message from an unexpected port is received
>> - Both `testSendReceive` and `testSendNoReceive` both have messages that use the methods name instead of just "hello"
>> 
>> Ran tiers 1-3 of tests as well as running this updated test to make sure it was stable
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unused imports, added more logging around messages received

test/jdk/java/net/DatagramSocket/DatagramSocketMulticasting.java line 330:

> 328:                         String.format("expected message %s, instead received %s%n", message, messageReceived));
> 329:                 break;
> 330:             }

Can you please re-format this to keep the lines at a sane length, it looks very messy to be adding 150+ lines to this test.

-------------

PR: https://git.openjdk.org/jdk/pull/12513