RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened [v5]
Darragh Clarke
duke at openjdk.org
Tue Feb 21 15:27:56 UTC 2023
> Updated `DatagramSocketMulticasting` to use Junit and also hardened the test to avoid occasional interference from other tests.
>
> - Test now uses Junit Assertions, in general if the assertion used had been `assertTrue(foo==bar)` I replaced it with `assertEquals(foo,bar)` though there are some cases where I used `assertTrue` or `assertFalse`
> - `testSendReceive` now retries up to 3 times if a message from an unexpected port is received
> - Both `testSendReceive` and `testSendNoReceive` both have messages that use the methods name instead of just "hello"
>
> Ran tiers 1-3 of tests as well as running this updated test to make sure it was stable
Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
fixed wrong ordering of variables in assertEquals
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12513/files
- new: https://git.openjdk.org/jdk/pull/12513/files/ed2c5174..08428a32
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12513&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12513&range=03-04
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/12513.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12513/head:pull/12513
PR: https://git.openjdk.org/jdk/pull/12513
More information about the net-dev
mailing list