RFR: 8278326: Socket close is not thread safe and other cleanup

[Jaikiran Pai]

On Thu, 5 Jan 2023 14:39:28 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> java.net.Socket is not specified to be thread safe but it is required to support async close. If you create an unbound Socket and close it at around the time that another thread is binding, connecting, or anything else that creates the underlying socket then it can leak. The simplest thing to do is to synchronize all methods but the underlying SocketImpl implementation is thread safe, and all we really need is for Socket (and ServerSocket) to synchronize the creation of the underlying socket (SocketImpl.create) with close. As part of this change I've replaced the 6 flags with a bit mask. A new test is added to the Socket/asyncClose directory to test closing concurrently with another operation, the test will detect if the closed Socket is connected to a SocketImpl with an open socket.
> 
> Related is that ServerSocket.implAccept can be overridden to provide the Socket to accept. Its behavior is unspecified when called with a Socket that isn't newly created/unbound and there are number of silly scenarios that can arise. I've changed implAccept to coordinate with close so that accept doesn't return a closed Socket that is connected to an underlying socket. A new test is added to exercise these scenarios.
> 
> There are a couple of random cleanup/formatting nits in this patch.

I've added some minor review comments, but overall the changes in this PR look good to me.

test/jdk/java/net/Socket/asyncClose/Leaky.java line 166:

> 164:             future1.get();
> 165:         } finally {
> 166:             future2.get();

Should we capture/report any exception thrown from `future1.get()`? In its current form that might be lost if even `future2.get()` throws some other exception.

test/jdk/java/net/Socket/asyncClose/Leaky.java line 217:

> 215:         }
> 216: 
> 217:         // call getSocket to get the value of the SO_REUSEADDR socket option

Typo? Should it be "call getOption ..."?

-------------

PR: https://git.openjdk.org/jdk/pull/11863