RFR: 8300176: URLEncoder/URLDecoder static fields should be private static final
Sergey Tsypanov
stsypanov at openjdk.org
Sat Jan 21 17:57:04 UTC 2023
On Fri, 20 Jan 2023 17:41:55 GMT, Darragh Clarke <duke at openjdk.org> wrote:
> Made the `static` fields `private static final`, updated the naming as well to reflect this.
>
> This meant I updated `URLDecoder` to set the `DEFAULT_ENCODING_NAME` itself since it had been previously getting it from `URLEncoder`.
>
> Since these fields are only referenced from inside the classes nothing else needed updated
src/java.base/share/classes/java/net/URLDecoder.java line 97:
> 95:
> 96: static {
> 97: DEFAULT_ENCODING_NAME = StaticProperty.fileEncoding();
Wouldn't it be more brief to move initializer to field declaration?
-------------
PR: https://git.openjdk.org/jdk/pull/12122
More information about the net-dev
mailing list