RFR: 8301004: httpclient: Add more debug to HttpResponseInputStream
Jaikiran Pai
jpai at openjdk.org
Wed Jan 25 01:58:04 UTC 2023
On Tue, 24 Jan 2023 16:36:42 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
> The AsyncExecutorShutdown test has been observed failing (rarely) in our CI. The root cause seems to be an assertion error in HttpResponseInputStream. More debug traces could help with diagnosing how we reached this assertion.
Marked as reviewed by jpai (Reviewer).
Marked as reviewed by jpai (Reviewer).
src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 565:
> 563: assert buffers.remainingCapacity() > 1
> 564: : "buffers capacity: " + buffers.remainingCapacity()
> 565: + "closed: " + closed + "failed: " + failed;
Hello Daniel, I think a space before `closed:` and `failed:` would be good. Other than that, this looks good.
-------------
PR: https://git.openjdk.org/jdk/pull/12169
More information about the net-dev
mailing list