RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v4]
Jaikiran Pai
jpai at openjdk.org
Wed Jan 25 07:02:07 UTC 2023
> Can I please get a review of this change which addresses https://bugs.openjdk.org/browse/JDK-8295944?
>
> As noted in the issue, the HttpClient testing helper infrastructure code resides in a default (unnamed) packages within the test hierarchy. The commit in this PR moves those classes into a specific package. The tests have been updated to refer to them correctly with proper package name references.
> Additionally as noted in the issue, the `@modules` declaration used in the httpclient tests, were all the same and were repeated in all these tests. The commit in this PR moves those module references into the `TEST.properties` to centralize such reference. Any test which needs additional modules can then use specific `@modules` declaration in the test definition.
>
> No functional changes have been done in this PR.
>
> tier1, tier2 and tier3 testing passed after these changes.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
review suggestion - remove more common usages of @modules
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12160/files
- new: https://git.openjdk.org/jdk/pull/12160/files/ec0a6889..7cee3fdc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12160&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12160&range=02-03
Stats: 118 lines in 18 files changed: 2 ins; 116 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/12160.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12160/head:pull/12160
PR: https://git.openjdk.org/jdk/pull/12160
More information about the net-dev
mailing list