RFR: 8301004: httpclient: Add more debug to HttpResponseInputStream [v2]
Daniel Fuchs
dfuchs at openjdk.org
Wed Jan 25 11:42:34 UTC 2023
On Wed, 25 Jan 2023 11:38:27 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> The AsyncExecutorShutdown test has been observed failing (rarely) in our CI. The root cause seems to be an assertion error in HttpResponseInputStream. More debug traces could help with diagnosing how we reached this assertion.
>
> Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:
>
> - Update src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java
> - Update src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java
src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 565:
> 563: assert buffers.remainingCapacity() > 1
> 564: : "buffers capacity: " + buffers.remainingCapacity()
> 565: + "closed: " + closed + "failed: " + failed;
Suggestion:
+ " closed: " + closed + "failed: " + failed;
src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 565:
> 563: assert buffers.remainingCapacity() > 1
> 564: : "buffers capacity: " + buffers.remainingCapacity()
> 565: + " closed: " + closed + "failed: " + failed;
Suggestion:
+ " closed: " + closed + " failed: " + failed;
-------------
PR: https://git.openjdk.org/jdk/pull/12169
More information about the net-dev
mailing list