Integrated: 8295944: Move the Http2TestServer and related classes into a package of its own
Jaikiran Pai
jpai at openjdk.org
Wed Jan 25 13:41:16 UTC 2023
On Tue, 24 Jan 2023 06:05:30 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which addresses https://bugs.openjdk.org/browse/JDK-8295944?
>
> As noted in the issue, the HttpClient testing helper infrastructure code resides in a default (unnamed) packages within the test hierarchy. The commit in this PR moves those classes into a specific package. The tests have been updated to refer to them correctly with proper package name references.
> Additionally as noted in the issue, the `@modules` declaration used in the httpclient tests, were all the same and were repeated in all these tests. The commit in this PR moves those module references into the `TEST.properties` to centralize such reference. Any test which needs additional modules can then use specific `@modules` declaration in the test definition.
>
> No functional changes have been done in this PR.
>
> tier1, tier2 and tier3 testing passed after these changes.
This pull request has now been integrated.
Changeset: 8a47429d
Author: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/8a47429dc065ad7645a40fa2350d043ef4606d92
Stats: 1226 lines in 135 files changed: 276 ins; 467 del; 483 mod
8295944: Move the Http2TestServer and related classes into a package of its own
Reviewed-by: dfuchs
-------------
PR: https://git.openjdk.org/jdk/pull/12160
More information about the net-dev
mailing list