RFR: 8300176: URLEncoder/URLDecoder static fields should be private static final [v2]

[Claes Redestad]

On Wed, 25 Jan 2023 14:54:55 GMT, Darragh Clarke <duke at openjdk.org> wrote:

> And as for testing, I ran some benchmarks on my local machine that did show a speed up after the changes, but this was my first time using JMH so I was wondering if you have any pointers @cl4es as to what settings/how many iterations should I run before I can be confident in any results it gives?

As a rule of thumb if you get the approximate same results when running the same benchmark back to back and the difference between your baseline and test results is decidedly larger than the sum of the errors then you can have a reasonably high confidence in the results.

If errors are too high for comfort (or effect too small) you should first consider if your benchmarking system can be made quieter (e.g. turning off browsers, slack, IDEs, turn off hyperthreading, turbo boost, apply firmware updates, put the box in a freezer, don't move, don't make a sound...!), then if you're still not getting comfortably consistent results you can increase the amount of forks, warmup and measurement iterations you're running with.

-------------

PR: https://git.openjdk.org/jdk/pull/12122