RFR: 8299325: java/net/httpclient/CancelRequestTest.java fails "test CancelRequestTest.testGetSendAsync("https://localhost:46509/https1/x/same/interrupt", true, true)"

[Jaikiran Pai]

On Thu, 26 Jan 2023 19:37:52 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> The CancelRequestTest has been observed failing (rare and intermittent, but at least twice) in our CI.
> This fix increases the timeout waiting for resources to be released after cancelling the request, and add more diagnosis to the test code.

Marked as reviewed by jpai (Reviewer).

test/jdk/java/net/httpclient/CancelRequestTest.java line 369:

> 367:                     }
> 368:                 }
> 369:                 if (!IOException.class.isAssignableFrom(cause.getClass())) {

Just to make it a bit easier to read, do you think we could change this to:


if (!IOException.class.isInstance(cause)) {
...

-------------

PR: https://git.openjdk.org/jdk/pull/12233