Integrated: 8310645: CancelledResponse.java does not use HTTP/2 when testing the HttpClient

Conor Cleary ccleary at openjdk.org
Wed Jul 5 11:07:19 UTC 2023


On Fri, 23 Jun 2023 12:13:47 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

> **Issue**
> In CancelledResponse.java the test only checks the HttpClient against HTTP/1.1 when cancelling a BodySubscriber while receiving data. 
> 
> **Solution**
> In the interest of more coverage, a new test has been created which performs the same checks against HTTP/2 to cover the client in the case of a HTTP/2 connection. A new test was created as it makes use of HttpTestServerAdapters to create the test servers. This is different to how this is performed in the original "CancelledResponse" test. There are some minor changes to how the testing is conducted with an element of randomness added to the new test.
> 
> As an open question to reviewers, the old test "CancelledResponse" and the new test "CancelledResponse2" could be merged into a single file and the HTTP/1.1 case could be updated to use more canonical testing methods as with "CancelledResponse2". Though there isn't a very pressing need for this and so it has not been included in this PR as of now.

This pull request has now been integrated.

Changeset: 00ac46c0
Author:    Conor Cleary <ccleary at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/00ac46c06d8a7154a007cd67092bd80226a02fc3
Stats:     258 lines in 1 file changed: 258 ins; 0 del; 0 mod

8310645: CancelledResponse.java does not use HTTP/2 when testing the  HttpClient

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/14625


More information about the net-dev mailing list