RFR: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
Daniel Fuchs
dfuchs at openjdk.org
Tue Jul 11 12:00:17 UTC 2023
On Tue, 11 Jul 2023 11:10:03 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 541:
>>
>>> 539: Iterator<?> iterator = currentListItr;
>>> 540: if (iterator != null && iterator.hasNext()) return 1;
>>> 541: if (!buffers.isEmpty() && buffers.peek() != LAST_LIST ) return 1;
>>
>> Should probably be:
>>
>>
>> if (iterator != null && iterator.hasNext() && Utils.hasRemaining(buffers)) return 1;
>
> do you mean
>
> if (iterator != null && iterator.hasNext() && Utils.hasRemaining(buffers.peek())) return 1; ?
Doh! Sorry ignore my suggestion. What you originally had seems reasonable. Give me some time to test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14810#discussion_r1259628299
More information about the net-dev
mailing list