RFR: 8308593: Add Keepalive Extended Socket Options Support for Windows [v2]
Michael McMahon
michaelm at openjdk.org
Thu Jul 20 14:55:43 UTC 2023
On Fri, 16 Jun 2023 17:19:28 GMT, Terry Chow <duke at openjdk.org> wrote:
>> The PR adds support for the keepalive extended socket options on Windows. For TCP_KEEPIDLE and TCP_KEEPINTVL, these options are supported starting from Windows 10 version 1709. TCP_KEEPCNT is supported starting from Windows 10 version 1703. Information on these socket options can be found [here](https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-tcp-socket-options).
>>
>> I've also corrected the `handleError()` function. On Windows, the error needs to be retrieved using `WSAGetLastError()` and error codes are prefixed with "WSA". Information on this can be found [here](https://learn.microsoft.com/en-us/windows/win32/winsock/error-codes-errno-h-errno-and-wsagetlasterror-2).
>>
>>>The error codes returned by Windows Sockets are similar to UNIX socket error code constants, but the constants are all prefixed with WSA.
>>
>>>Error codes set by Windows Sockets are not made available through the errno variable.
>>
>> No new tests were added as the existing tests should cover this.
>
> Terry Chow has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> Support keepalive extended socket options for Windows
Looks good to me, subject to copyright update.
-------------
Marked as reviewed by michaelm (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14232#pullrequestreview-1539463489
More information about the net-dev
mailing list