RFR: 8308593: Add Keepalive Extended Socket Options Support for Windows [v3]
Jaikiran Pai
jpai at openjdk.org
Fri Jul 21 10:58:44 UTC 2023
On Thu, 20 Jul 2023 16:51:53 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> On a side note, the test could be more verbose - currently it is not clear if the test passes because the options worked or because they were unsupported. But that's preexisting and not much of a problem anyway.
Agreed. When I tested this PR in our CI, I had to locally update `TcpKeepAliveTest.java` to make sure the options were indeed being considered. I'll open a separate JBS issue and propose a PR with these log message changes in that test.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14232#issuecomment-1645394284
More information about the net-dev
mailing list