RFR: 8309200: java/net/httpclient/ExecutorShutdown fais intermittently, if connection closed during upgrade [v2]
Daniel Jeliński
djelinski at openjdk.org
Fri Jun 2 09:30:06 UTC 2023
On Thu, 1 Jun 2023 11:09:37 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> The ExecutorShutdown test has been observed failing intermittently, notably if by misfortune the shutdown sequence causes a connection to get aborted while upgrading. The issue is that the `ConnectionAborter` class that allows to mark the connection as being scheduled for closing before a handle to the connection is actually available isn't forwarding the original exception for which closing the connection was requested. When the connection is eventually closed, a generic `IOException: connection closed locally` is raised at the `SocketTube` level, which unfortunately can race with the original cause.
>>
>> The fix makes it possible to relay the original cause to the place where the IOException is raised, in order to set it as the cause of the new exception.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>
> Review feedback
Marked as reviewed by djelinski (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/14251#pullrequestreview-1456989514
More information about the net-dev
mailing list