RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

Alan Bateman alanb at openjdk.org
Tue Jun 6 07:19:03 UTC 2023


On Fri, 2 Jun 2023 08:03:01 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> There are cases in the sctp coding where a function sctpHandleSocketErrorWithMessage would be beneficial (similar to existing handleSocketErrorWithMessage) to provide more detail what failed.
> 
> Additionally sctpHandleSocketErrorWithMessage was a bit modified (added errno handling for ENOTCONN from handleSocketErrorWithMessage).

I see this was integrated without a reviewer in the area but I think the changes are okay.

src/jdk.sctp/unix/native/libsctp/SctpNet.c line 147:

> 145:     errno = errorValue;
> 146:     if (message == NULL) {
> 147:         JNU_ThrowByNameWithLastError(env, xn, "NioSocketError");

"NioSocketError" is confusing as the failing message, maybe we should change that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14280#issuecomment-1578057691
PR Review Comment: https://git.openjdk.org/jdk/pull/14280#discussion_r1219054386


More information about the net-dev mailing list