RFR: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address [v4]

[Jaikiran Pai]

On Tue, 6 Jun 2023 14:53:40 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge latest master branch changes
>>  - wrapping into brackets is no longer needed
>>  - use HttpRequestImpl.getAddress() to lookup cache key instead of HttpRequestImpl.getURI()
>>  - 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address
>
> Marked as reviewed by dfuchs (Reviewer).

Hello @dfuch, @djelinski, I've done some minor changes to this PR to have `keyFor` accept a `HttpRequestImpl` instance so that it's clear where the `InetSocketAddress`es get sourced from when constructing the cache key. CI tests with this latest change continue to pass. Requesting a fresh review of this change, please.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13456#issuecomment-1579951670