Integrated: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address

[Jaikiran Pai]

On Thu, 13 Apr 2023 11:13:07 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fix the issue reported in https://bugs.openjdk.org/browse/JDK-8305906?
> 
> As noted in that issue, when IPv6 hosts are involved, the HttpClient on certain occasions can end up caching the connection with a key which doesn't match with the key which is then used in a subsequent request against the same target host. 
> 
> The commit in this PR now wraps the IPv6 address in a square bracket consistently so that the correct key is used both during storing the connection in the pool and when looking up.
> 
> A new jtreg test has been added which reproduces this issue without the fix and verifies the fix.

This pull request has now been integrated.

Changeset: 3ccb3c0e
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3ccb3c0e09f9a414229d3f76031f3fc8f271c936
Stats:     194 lines in 3 files changed: 183 ins; 4 del; 7 mod

8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address

Reviewed-by: djelinski, dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/13456