RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

Jaikiran Pai jpai at openjdk.org
Fri Jun 9 15:47:56 UTC 2023


On Fri, 9 Jun 2023 15:01:47 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   newline at end of test file
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 186:
> 
>> 184:      * @apiNote Used to create the application class path.
>> 185:      */
>> 186:     URLClassPath(String cp, URLStreamHandler jarHandler, boolean skipEmptyElements) {
> 
> This is a special constructor for the application class path so shouldn't have the jarHandle parameter. This should allow you to drop the changes to ClassLoaders.

Thank you Alan for the suggestion. I've updated the PR accordingly. The test continues to pass.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14395#discussion_r1224470836


More information about the net-dev mailing list