RFR: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines [v2]
Daniel Fuchs
dfuchs at openjdk.org
Wed Jun 14 11:02:04 UTC 2023
> The HttpClient uses `Instant.now()` to create deadlines for timeouts. This could have undesirable effects since `Instant.now()` is linked to the wall clock, which is not monotonic. This fix changes the HttpClient to use a monotonic instant source based on `System.nanoTime()` for the purpose of setting and comparing deadlines.
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'master' into TimeSource
- 8309939
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14450/files
- new: https://git.openjdk.org/jdk/pull/14450/files/1ab59db0..e30a6834
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=00-01
Stats: 9503 lines in 264 files changed: 1433 ins; 7240 del; 830 mod
Patch: https://git.openjdk.org/jdk/pull/14450.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14450/head:pull/14450
PR: https://git.openjdk.org/jdk/pull/14450
More information about the net-dev
mailing list