RFR: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines [v3]
Daniel Fuchs
dfuchs at openjdk.org
Wed Jun 14 12:44:30 UTC 2023
> The HttpClient uses `Instant.now()` to create deadlines for timeouts. This could have undesirable effects since `Instant.now()` is linked to the wall clock, which is not monotonic. This fix changes the HttpClient to use a monotonic instant source based on `System.nanoTime()` for the purpose of setting and comparing deadlines.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
Review feedback
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14450/files
- new: https://git.openjdk.org/jdk/pull/14450/files/e30a6834..35da58e2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=01-02
Stats: 30 lines in 3 files changed: 11 ins; 11 del; 8 mod
Patch: https://git.openjdk.org/jdk/pull/14450.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14450/head:pull/14450
PR: https://git.openjdk.org/jdk/pull/14450
More information about the net-dev
mailing list