RFR: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines [v5]
Daniel Fuchs
dfuchs at openjdk.org
Wed Jun 14 15:39:10 UTC 2023
> The HttpClient uses `Instant.now()` to create deadlines for timeouts. This could have undesirable effects since `Instant.now()` is linked to the wall clock, which is not monotonic. This fix changes the HttpClient to use a monotonic instant source based on `System.nanoTime()` for the purpose of setting and comparing deadlines.
Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
Use Deadline rather than Instant
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14450/files
- new: https://git.openjdk.org/jdk/pull/14450/files/4636ccb0..e5f6cd60
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=03-04
Stats: 297 lines in 7 files changed: 265 ins; 3 del; 29 mod
Patch: https://git.openjdk.org/jdk/pull/14450.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14450/head:pull/14450
PR: https://git.openjdk.org/jdk/pull/14450
More information about the net-dev
mailing list