RFR: 8309939: HttpClient should not use Instant.now() as Instant source for deadlines [v6]

Daniel Fuchs dfuchs at openjdk.org
Mon Jun 19 09:50:14 UTC 2023


> The HttpClient uses `Instant.now()` to create deadlines for timeouts. This could have undesirable effects since `Instant.now()` is linked to the wall clock, which is not monotonic. This fix changes the HttpClient to use a monotonic instant source based on `System.nanoTime()` for the purpose of setting and comparing deadlines.

Daniel Fuchs has updated the pull request incrementally with two additional commits since the last revision:

 - whitespaces
 - Change Deadline::toString

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14450/files
  - new: https://git.openjdk.org/jdk/pull/14450/files/e5f6cd60..e512b7cb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14450&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14450.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14450/head:pull/14450

PR: https://git.openjdk.org/jdk/pull/14450


More information about the net-dev mailing list