RFR: 8310330: HttpClient: debugging interestOps/readyOps could cause exceptions and smaller cleanup [v3]

Daniel Fuchs dfuchs at openjdk.org
Tue Jun 20 11:32:25 UTC 2023


On Tue, 20 Jun 2023 06:38:21 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unused getFormat
>
> src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java line 282:
> 
>> 280:                 && logger.isLoggable(level)) {
>> 281:             logger.log(level, unused,
>> 282:                     format(new StringBuilder(), msg, null).toString(),
> 
> `getFormat` is no longer used, can you remove it?

Oh - that's an oversight indeed. Thanks for spotting it. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14546#discussion_r1235127205


More information about the net-dev mailing list