RFR: 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests

Jaikiran Pai jpai at openjdk.org
Fri Jun 23 12:43:17 UTC 2023


Can I please get a review of this test-only change which addresses https://bugs.openjdk.org/browse/JDK-8310731?

As noted in that issue, before the changes in this PR, the test servers that we created for HTTP/1.1 testing in `java/net/httpclient` tests weren't configured to use a `javax.net.ssl.SNIMatcher` which resulted in the SNI name extension from the client being ignored. The commit in this PR addresses that by configuring such instances with a relevant `SNIMatcher`. 

No new tests have been added given the nature of this change, but existing tests in `java/net/httpclient` continue to pass with this change.

-------------

Commit messages:
 - 8310731: Configure a javax.net.ssl.SNIMatcher for the HTTP/1.1 test servers in java/net/httpclient tests

Changes: https://git.openjdk.org/jdk/pull/14626/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14626&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8310731
  Stats: 317 lines in 19 files changed: 264 ins; 24 del; 29 mod
  Patch: https://git.openjdk.org/jdk/pull/14626.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14626/head:pull/14626

PR: https://git.openjdk.org/jdk/pull/14626


More information about the net-dev mailing list