RFR: 8277969: HttpClient SelectorManager shuts down when custom Executor rejects a task [v9]

[Daniel Fuchs]

On Mon, 26 Jun 2023 12:10:33 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed accepted exception logging in tests
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java line 1056:
> 
>> 1054:                 abortPendingRequests(owner, t);
>> 1055:             }
>> 1056:             Set<SelectionKey> keys = new HashSet<>();
> 
> I'm not quite understand, what for is this `keys` are here?
> Nothing happens with this collection after `addAll` call

Good observation. Probably meant to cancel the keys, but that will happen anyway when connections are closed (or the selector is closed). Maybe we should get rid of that collection.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/7196#discussion_r1242159809