RFR: JDK-8309591: Socket.setOption(TCP_QUICKACK) uses wrong level

Michael McMahon michaelm at openjdk.org
Tue Jun 27 10:52:04 UTC 2023


On Tue, 27 Jun 2023 09:23:49 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

> Please review the simple fix for the issue [JDK-8309591](https://bugs.openjdk.org/browse/JDK-8309591). In this issue sys call is incorrectly setting the socket option(TCP_QUICKACK) at wrong level(SOL_TCP).  After fix all the existing tests are passing.
> 
> Note: I did the similar changes for AIX port as well but I don’t have AIX to test it locally.

Unfortunate that the original mistake was a valid option itself and we were previously setting SO_PRIORITY to a value of 1. Change looks fine anyway.

-------------

Marked as reviewed by michaelm (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14671#pullrequestreview-1500546836


More information about the net-dev mailing list