RFR: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition

Alan Bateman alanb at openjdk.org
Wed Jun 28 13:23:02 UTC 2023


On Wed, 28 Jun 2023 09:45:08 GMT, Darragh Clarke <dclarke at openjdk.org> wrote:

> Bumped timeout limit to `+20_000` to deal with occasional failure and bring the test in line with other tests like [SleepWithDuration](https://github.com/openjdk/jdk/blob/c3f10e847999ec254893de5a1a5de32fd07f715a/test/jdk/java/lang/Thread/SleepWithDuration.java#L46) and [JoinWithDuration](https://github.com/openjdk/jdk/blob/c3f10e847999ec254893de5a1a5de32fd07f715a/test/jdk/java/lang/Thread/JoinWithDuration.java#L67) .
> 
> I had considered making a Util class to contain `checkDuration` but decided against it because as far as I'm aware it is only these 3 classes that would share it, though I would be open to adding it if people think it adds value

This is consistent with other tests where we've done the same.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14690#pullrequestreview-1503074368


More information about the net-dev mailing list