RFR: 8311162: Simplify and modernize equals and hashCode for java.net
Michael McMahon
michaelm at openjdk.org
Fri Jun 30 11:40:55 UTC 2023
On Fri, 30 Jun 2023 09:17:42 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
> Please review this PR to use modern APIs and language features to simplify `equals` and `hashCode` for the java.net package.
>
> Note, in NetworkInterface we could do even more and change this:
>
> for (InetAddress thisAddr : this.addrs) {
> boolean found = false;
> for (InetAddress thatAddr : that.addrs) {
> if (thisAddr.equals(thatAddr)) {
> found = true;
> break;
> }
> }
> if (!found) {
> return false;
> }
> }
> return true;
>
> to this:
>
> return Set.of(that.addrs).containsAll(Set.of(this.addrs));
>
> But arguably, the first option is already better enough than what was there before.
The change looks good to me, per the webrev
-------------
Marked as reviewed by michaelm (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14726#pullrequestreview-1507034348
More information about the net-dev
mailing list